replace multiprocessing.Pool with concurrent.futures.ProcessPoolExecutor #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3
When running the test, I noticed that
max_tasks_per_childwas only added in python 3.11 to concurrent.futures, so this change would require changing the requirements or removing the max_tasks_per_child. I can understand if this is not something you are willing to do and will simply run my own fork for my usage. (At least lookup_table seems to be running fine on newer python).I'm happy to adjust the code to be able to bump up the python version if that is something you'd be interested in.